JavaScriptHelper::toJsObject Bug

[what4893]

There is a bad assumption on line 110 of the JavaScriptHelper? class. When converting a PHP array beginning with a zero (i.e. array(0,3,5)) this function uses if($strList) in which case 0 will evaluate to false generating the incorrect comma sequence and lumping the first two elements together as 03. A simple fix would be to use strlen() around $strList or some other check.

[vaibhav]

Thanks for point the problem out. I think that using strlen is the 'only' way to fix this without changing other things :) Please apply the patch and test if it works fine and let us know if it is okay. We shall then commit it.

[vaibhav]

Fix for JavaScriptHelper? class by using strlen function

[what4893]

Patch worked perfect for me. Thanks!

[vaibhav]

Thanks a lot for the feedback. I would be committing it soon then.

[vaibhav]

(In [1497]) Fixes #865