Ticket #849 (closed defect: fixed)

Opened 12 months ago

Last modified 11 months ago

QDataGrid top (header) row height fixed

Reported by: vaibhav Owned by:
Priority: important Milestone: 2.1.1
Component: QControls Version: 2.1.0 Stable
Keywords: Cc:

Description

I noticed that when trying to use numerical values for header row of QDataGrid, it was not being put to effect (because the height was sent as a number without unit). The attached patch fixes the problem

Attachments

fixing-datagrid-header-row.patch Download (0.7 KB) - added by vaibhav 12 months ago.
QDataGrid header row height fix.

Change History

Changed 12 months ago by vaibhav

QDataGrid header row height fix.

Changed 11 months ago by vakopian

It looks like the condition branches are reversed: for the is_numeric case it should have "px", otherwise use it as is. So just putting "!" in the condition would fix this issue. Do you agree?

Changed 11 months ago by vaibhav

Hmm...That was the precise thing! I agree.

Changed 11 months ago by vakopian

  • status changed from new to closed
  • resolution set to fixed

(In [1488]) fixes #849

Note: See TracTickets for help on using tickets.