Ticket #820 (closed enhancement: wontfix)

Opened 14 months ago

Last modified 14 months ago

URL Encoding of RequestUri and QueryString

Reported by: vaibhav Owned by: somebody
Priority: important Milestone: 2.1.1
Component: Other Version: 2.1.0 Stable
Keywords: Cc:

Description

QApplicationBase has variables for Request URI and Query String. However, sometimes we do need to encode the URL (such as for redirection purposes). This functionality might be needed on all pages of an application. Such as on my application, the 'login' link at all times contains the current URL with it as the URL to redirect to after login is successful. However, it fails if the present url has more than one variable in the Query string.

The attached patch adds the functionality.

Attachments

Qapplication_QueryString_and_RequestUri_urlencoded.patch Download (1.8 KB) - added by vaibhav 14 months ago.
Patch to add the functionality for URL encoding the RequestUri? and QueryString (stored in QuesryStringEncoded? and RequestUriEncoded?)

Change History

Changed 14 months ago by vaibhav

Patch to add the functionality for URL encoding the RequestUri? and QueryString (stored in QuesryStringEncoded? and RequestUriEncoded?)

Changed 14 months ago by vakopian

I don't mind to add those, but first this is simple enough to do it in your own code (just call urlencode()), and second, typically it's better to keep the redirect URL in the session rather than in the login URL. Of course if you're trying to handle the "no-cookie" situation, then you need it in the URL.
Is there any other reason to have those built-in?

Changed 14 months ago by vaibhav

Hmmm. URL in the session! That is a fine point. I think you are right. It only adds overhead without providing much meat for everyone who uses QCubed. Thanks.

BTW. I think this is the '5th' useless ticket I created :P I am still learning things.

Regards,
Vaibhav

Changed 14 months ago by vakopian

  • status changed from new to closed
  • resolution set to wontfix
Note: See TracTickets for help on using tickets.