Ticket #780 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

Allow QDialog to be a child of QControl

Reported by: vakopian Owned by:
Priority: must Milestone: 2.1
Component: QControls Version: 2.0.2 Stable
Keywords: Cc:

Description

Currently if QDialog is a child of a QControl (rather than QForm) RenderOutput() will generate the wrong output for ajax requests (it will but a <control> tag inside parent's existing <control> tag).
The attached patch fixes it.

Attachments

ticket780.patch Download (1.0 KB) - added by vakopian 3 months ago.
dialog.php Download (1.0 KB) - added by vakopian 3 months ago.
dialog.tpl.php Download (215 bytes) - added by vakopian 3 months ago.

Change History

Changed 3 months ago by vakopian

Changed 3 months ago by vakopian

  • summary changed from Allow QDialog to bi a child of QControl to Allow QDialog to be a child of QControl

Changed 3 months ago by vakopian

  • status changed from new to in_QA

Changed 3 months ago by vakopian

Even though this patch fixes the AJAX response issue, it seems there is still a problem in having a QDialog as a child of another QControl. I attach an example which demonstrates the problem.
If I completely remove the RenderOutput() override from QDialog, this example works.

Since this was added by sp, I'm not sure what was the reason for this override.
sp, could you please take a look at this, and see if you still think that override is needed?

Changed 3 months ago by vakopian

Changed 3 months ago by vakopian

Changed 3 months ago by sp

Whatever I was trying to fix, I can't reproduce any more. Removing RenderOutput? appears to work fine.

Changed 3 months ago by vakopian

  • status changed from in_QA to closed
  • resolution set to fixed

(In [1408]) remove the RenderOutput?() override. Fixes #780

Note: See TracTickets for help on using tickets.