QListBox with QSelectionMode::Multiple doesn't set type required for js escaping

[banetbi]

When using a QListBox with QSelectionType::Multiple in an AjaxAction? the following javascript error occurs:

strPostValue.replace is not a function /assets/_core/js/qcubed.js Line 196

upon further inspection this happens because qcubed.js is trying to escape the values. qcubed.js is looking for a type of select-multiple which is not being included in the GetAttributes? call of QListBoxBase.class.php

I was able to resolve the issue by overriding the GetAttributes? function with the following in QListBox.class.php

public function GetAttributes?($blnIncludeCustom = true, $blnIncludeAction = true) {

$strToReturn = parent::GetAttributes?($blnIncludeCustom, $blnIncludeAction);

if ($this->intRows)

$strToReturn .= sprintf('size="%s" ', $this->intRows);

if ($this->strSelectionMode == QSelectionMode::Multiple) {

$strToReturn .= 'multiple="multiple" ';

$strToReturn .= 'type="select-multiple" ';

}

return $strToReturn;

}

[vakopian]

This has been broken by the move to jQuery, because $j(this).attr("type") does not return the type property of the DOM element (which is what was used prior to jQuery).
I don't think the proposed solution is the best solution since it would put a non-standard "type" attribute on the select tag.
It's much easier to fix qcubed.js.
Patch is attached, please test.

[alex94040]

Good one, vakopian!

[vakopian]

(In [1388]) reviewed by alex. Fixes #763