Ticket #738 (closed defect: fixed)

Opened 10 months ago

Last modified 6 months ago

Incomplete PostgreSQL Adapter

Reported by: vaibhav Owned by:
Priority: minor Milestone: 2.1
Component: Database adapter Version: 2.0.2 Stable
Keywords: PostgreSQL, timestamp with time zone Cc:

Description

When using the PostgreSQL (currently version 8.4.8) with QCubed, I found that the database reports an error as below.

PostgreSql? Error: Unsupported Field Type: timestamp with time zone

I looked into the code in includes/qcubed/_core/database/QPostgreSqlDatabase.class.php and found that it was actually not supported, indeed.

Since PostgreSQL is one of the MAJOR open source databases and supports the 'timestamp with time zone' datatype, here is the patched file.

The patch is actually of only two lines (one line code, another comment). The lines are 672, 673.

Attachments

QPostgreSqlDatabase.class.php Download (20.9 KB) - added by vaibhav 10 months ago.
The file with the patch. The line number 672 is the modified line.
ticket738.patch Download (0.7 KB) - added by vakopian 6 months ago.
the fix as patch

Change History

Changed 10 months ago by vaibhav

The file with the patch. The line number 672 is the modified line.

Changed 10 months ago by vaibhav

Here is how the error looks without the patch I applied : <a href=" http://tinypic.com?ref=2vvw8w6" target="_blank"><img src=" http://i56.tinypic.com/2vvw8w6.png" border="0" alt="Image and video hosting by TinyPic?"></a>

Changed 9 months ago by VexedPanda

Please create a .patch file for review.

Changed 6 months ago by vakopian

the fix as patch

Changed 6 months ago by vakopian

  • status changed from new to closed
  • resolution set to fixed

(In [1326]) Fixes #738

Note: See TracTickets for help on using tickets.