Ticket #699 (in_QA defect)

Opened 2 years ago

Last modified 19 months ago

QImageFileAsset: MaxHeight typo

Reported by: n0ur Owned by:
Priority: must Milestone: 1.1.4
Component: QControls Version: 1.1.3 Maintenance
Keywords: Cc:

Description

Hello!
Inside QImageFileAsset.class.php, it says:

case 'MaxHeight':
    try {
        return ($this->intMinHeight = QType::Cast($mixValue, QType::Integer));
	} ..

When it should be 

    $this->intMaxHeight

:D

Attachments

patch699.patch Download (501 bytes) - added by alex94040 2 years ago.
Patch v1

Change History

Changed 2 years ago by alex94040

  • status changed from new to in_QA
  • summary changed from QImageFileAsset tiny mistake to QImageFileAsset: MaxHeight typo
  • milestone changed from 2.1.0 to 2.0.3

great catch!

Changed 2 years ago by alex94040

Patch v1

Changed 2 years ago by alex94040

This might be relevant for other branches (1.0 and 1.1).

Changed 2 years ago by basilieus

Hah, nice catch! Funny to think that just two characters can change everything..

Changed 20 months ago by vakopian

  • status changed from in_QA to closed
  • resolution set to fixed

(In [1290]) Patch by alex, reviewed by basilieus and vakopian. Fixes #699

Changed 19 months ago by VexedPanda

  • status changed from closed to new
  • version changed from 2.0.2 Stable to 1.1.3 Maintenance
  • resolution fixed deleted

Reopening for back-porting.

Changed 19 months ago by VexedPanda

  • status changed from new to in_QA

Changed 19 months ago by vakopian

  • milestone changed from 2.0.3 to 1.1.4
Note: See TracTickets for help on using tickets.