Ticket #482 (closed enhancement: fixed)

Opened 5 months ago

Last modified 5 months ago

put bindings of events into .ready()

Reported by: kmeirlaen Owned by: somebody
Priority: important Milestone: 2.0.0
Component: Other Version: 1.0.0 Stable
Keywords: Cc:

Description

jQuery best practices are to put bindings of events in
$j(document).ready()

Attachments

ticket482.v1.patch (1.5 kB) - added by kmeirlaen 5 months ago.

Change History

Changed 5 months ago by kmeirlaen

Changed 5 months ago by kmeirlaen

  • status changed from new to in_QA

Changed 5 months ago by VexedPanda

I thought the issue with this approach was that j.ready() wasn't triggered in certain situations, such as ajax responces.

Changed 5 months ago by kmeirlaen

yeah, I remember we had a discussion about that :)
Now that every example is working (yes, if you apply all patches they do!) it was more easy to convert it.
see chat log: http://qcu.be/bot/log/qcubed/2010-01-28

but now that does not seem to be an issue any more :) when a new control is rendered, the events are now bound to the control with QApplication::ExecuteJavascript?

Changed 5 months ago by alex94040

  • summary changed from bring back .ready() to put bindings of events into .ready()

Changed 5 months ago by alex94040

  • status changed from in_QA to closed
  • resolution set to fixed

Changelist [794] committed this fix.

Note: See TracTickets for help on using tickets.