Ticket #421 (closed defect: fixed)

Opened 7 months ago

Last modified 2 months ago

Unneded globals in QFormBase

Reported by: VexedPanda Owned by: somebody
Priority: minor Milestone: 1.1.2
Component: QForms Version: 1.1.1 Stable
Keywords: Cc:

Description

More info at
http://www.qcodo.com/issues/view.php/48

Attachments

patch421.patch (1.9 kB) - added by alex94040 2 months ago.
Here's the patch

Change History

Changed 7 months ago by alex94040

  • milestone changed from 1.0.2 Stable to 1.0.3 Stable

Changed 6 months ago by alex94040

This has no impact whatsoever - no user issue, no performance implications, nothing. I suggest won't fixing this.

Changed 6 months ago by VexedPanda

Cleaned up and more readable code seems worthy of a fix to me.

Changed 6 months ago by alex94040

Fiiiiiiine :-)

Changed 3 months ago by VexedPanda

  • status changed from new to in_QA

http://github.com/qcodo/qcodo/commit/45c7715583ff145aaf123b8411c4eb9d55c7361f

Changed 2 months ago by alex94040

Here's the patch

Changed 2 months ago by VexedPanda

Thank you! :)
If it tests ok, I'd say commit. :)

Changed 2 months ago by alex94040

  • version changed from 1.0.0 Stable to 1.1.1 Stable

This patch doesn't want to apply to 1.0 branch due to merge conflicts. Low priority/impact = not applying to 1.0.

Changed 2 months ago by alex94040

  • status changed from in_QA to closed
  • resolution set to fixed

(In [863]) Fixes #421 (Unneded globals in QFormBase). Code by Mike Ho; ported from Github by alex94040. Reviewed by VexedPanda?. This is for both the 1.1 and the 2.0 branches.

Changed 2 months ago by alex94040

  • milestone changed from 1.0.3 Legacy Maintenance to 1.1.2
Note: See TracTickets for help on using tickets.