Supporting images on QButtons through HTML <button> tag

[grossini]

the <button> tag of HTML 4.0 let us create colorful buttons that can be decorated with both images and fancy text.

At moment only text con be personalized in QButton.

With the proposed patched QButtonBase.class we can use <button> </button> tag introduced by HTML 4.0 and our ->text attribute can contain image.
e.g. $this->Text = '<img src="' . VIRTUAL_DIRECTORY . IMAGE_ASSETS . '/save_16.png">' . 'Download CVS';

[grossini]

proposed QButtonBase.class with mod. function GetControlHTML

[alex94040]

Re-submitting previous contribution as a patch file for easy reviewing

[alex94040]

Grossini, thanks so much for your contribution! I reviewed the code and tested it, and everything looks good. I think it's ready to check in to the core!

[alex94040]

Checked in - changelist [682].

[dugokontov]

why don't you use QImageButton instead?

[alex94040]

LOL good question! I actually didn't know of the existence of a QImageButton, LOL. I guess now a regular button can be used in place of a QImageButton, which is not a bad thing :-)

[VexedPanda]

Is the <button> tag recognized by older browsers? I've got some reservations switching the core QButton over to this. I'd have prefered the introduction of a new QControl.

[alex94040]

Button tag browser support matrix: http://webdesign.about.com/od/htmltags/p/bltags_button.htm