Ticket #397 (closed defect: fixed)

Opened 7 months ago

Last modified 6 months ago

PluginConfigParser - Make examples/ and includes/ not mandatory

Reported by: akrohn Owned by: alex94040
Priority: important Milestone: 1.1.1 Stable
Component: Plugin Manager Version: 1.1 Development
Keywords: plugin config Cc:

Description

Current plugin system is control oriented. But I'm currently working on a css plugin that installs no control. It crashed when I installed with only using:

$components = array();

// Taking the YAML contents
$components[] = new QPluginCssFile("yaml");
$components[] = new QPluginCssFile("images");
$components[] = new QPluginCssFile("css");

$objPlugin->addComponents($components);
$objPlugin->install();

Reason: files in /includes and examples/ were mandatory. This patch corrects that and checks if it exists, before parsing it.

Attachments

QPluginConfigParser.class.diff (1.7 kB) - added by akrohn 7 months ago.
examples/ and includes/ not mandatory anymore

Change History

Changed 7 months ago by akrohn

examples/ and includes/ not mandatory anymore

Changed 7 months ago by VexedPanda

Hmm, wouldn't it be easier for us to just initialize those two arrays instead?

Changed 7 months ago by alex94040

  • status changed from new to in_QA

In my mind, checking for null versus initializing the array are both good solutions. I'd be fine shipping the patch as-is.

Changed 7 months ago by alex94040

  • status changed from in_QA to closed
  • resolution set to fixed

(In [688]) Fixes #397: PluginConfigParser? - Make examples/ and includes/ not mandatory. Code by akrohn, reviewed by alex94040.

Changed 6 months ago by akrohn

Checked the changeset and it includes three new files that seem to belong to the autocomplete plugin. Are they correct?

Changed 6 months ago by alex94040

Yeah I screwed up that changelist. I fixed it in a later changelist.

Note: See TracTickets for help on using tickets.