codegen entering forbidden directories

[marcosdsanchez]

codegen is entering to SVN and CVS directories when it shouldn't.
I attach a patch with the solution and I added git directory to the forbidden list.

[VexedPanda]

There's a ton of formatting changes in that diff making it harder to read. Mind re-rolling?

[marcosdsanchez]

Main difference is here:

I added

  /**
   * @var string[] array of directories to be excluded in codegen
   * @access protected
   */
   protected static $strDirectoriesToExcludeArray = array('.','..','.svn','.cvs','.git')

and replaced

((!in_array($strModuleName,self::$strDirectoriesToExcludeArray)) &&

instead of
if (($strModuleName != '.') && ($strModuleName != '..') && ($strModuleName != 'SVN') && ($strModuleName != 'CVS') &&

Lines 266 and 281

[marcosdsanchez]

re-rolled patch

[VexedPanda]

Some comments:
I worry about backwards compatability, let's make sure "svn" is also in the ignore list, same as before.
Can we move the array_map calls outside the loops? Optionally, we could remove it entirely and just tell the user that entries in the array must be lower case.

Also, is there any way that non-ascii filenames could break strtolower? I guess specifically it only matters if it could possibly mangle a filename into one that matched the ignore list, which seems unlikely, but worth checking.

[marcosdsanchez]

This was commited in qcodo:
http://github.com/qcodo/qcodo/commit/9aec5390d3d32ee2e973133c78b4cab8685c893b

[alex94040]

The latest patch still doesn't work on my TortoiseSVN. It needs to be re-rolled: to actually work as a patch, and to include comments from Vexed.

@Vexed On strtolower: I really don't think this can happen. Strtolower claims to work well with Intl characters (http://php.net/manual/en/function.strtolower.php)

[VexedPanda]

Try this one.

[alex94040]

(In [934]) Fixes #388 (codegen entering forbidden directories). Code by Marcos and VexedPanda?; small last-minute fix by alex94040. This checkin is for 1.1.

[alex94040]

(In [935]) Fixes #388 (codegen entering forbidden directories). Code by Marcos and VexedPanda?; small last-minute fix by alex94040. This checkin is for 2.0.

[alex94040]

Fixed for 1.1 and 2.0 - I did have to resolve some more merge conflicts. Codegen code for 1.0 is considerably different, so let's not waste time porting this small fix to an ancient version.