Enable add External JS

[enzo]

Sometimes we need to load external JS files for instance

ad systems
CDN services
etc

I did a patch to enable include external javascript files in our applications

[scottux]

I think this is necessary, but that the method proposed in the patch is a bit over thought. Rather than adding a switch to the function, we could simply check to see if the script location starts with http i.e.

foreach ($strJavaScriptArray as $strScript) {	
			if(strpos($strScript, "http") === 0){
				$ret .= sprintf('<script type="text/javascript" src="%s"></script>', $strScript);
			}else{
				$ret .= sprintf('<script type="text/javascript" src="%s/%s"></script>', __VIRTUAL_DIRECTORY__ . __JS_ASSETS__, $strScript);
			}
			$ret .= "\r\n";
		}

I pulled this out of some code I had done for the QPage class where I need the same functionality.

[alex94040]

Yeah, the approach offered by scottux does seem a bit lighter. Let's go with that one.

[alex94040]

Moving out to 1.2.

[VexedPanda]

Dupe of #335

[alex94040]

I'm reactivating this ticket as #335 is much more a philosophical discussion about how JS files are to be included, and this is a practical very small sub-case (enabling external JS files, with the prime case of CDN of jQuery).

[alex94040]

v2 of the patch, works like a charm. Ready for review.

[mikederfler]

I am using the same approach as in patch v2 and for me it works really great.

[vakopian]

Alex,

Not sure if the changes in the lines where DOCROOT and SUBDIRECTORY are defined were intentional (lines 61 and 63). If not, please revert these two lines.

Otherwise, looks good, please commit.

[alex94040]

(In [1366]) Fixes #362 (Enable add External JS). Code by scottux + alex94040, review by vakopian.

[alex94040]

Deployed to the examples site! Yay, it's now working using the Google jQuery CDN!!