Ticket #240 (closed defect: fixed)

Opened 15 months ago

Last modified 10 months ago

Natively supporting servers with Magic Quotes=ON out of the box

Reported by: alex94040 Owned by: somebody
Priority: minor Milestone: 1.1
Component: Website Version: 1.0.0 RC2
Keywords: Cc:

Description

The QFCKEditor example on the examples site (examples.qcu.be), adding smiley causes a funny behavior with quotes ''. I am not able to reproduce this effect on my local box. This is most likely because of the magic quotes setting on that box.

Reported at http://qcu.be/content/file-asset-example-access-denied-upload-folder#comment-1612

Attachments

ticket240.patch (3.0 kB) - added by VexedPanda 13 months ago.
Here's the changes needed to add it to core, I'll see about modifying the config validator to warn about magic quotes.
magic_quotes_check.patch (0.6 kB) - added by VexedPanda 13 months ago.
*Untested*! This should check for magic quotes, but allow config to continue regardless.
ticket240v2.patch (3.2 kB) - added by VexedPanda 13 months ago.
Updated to work with servers that don't support REMOTE_USER

Change History

Changed 15 months ago by VexedPanda

Perhaps we should include this in core:
http://trac.qcu.be/projects/qcubed/wiki/MagicQuotes

As well as fix the magic quotes setting on this box.

Changed 13 months ago by MikeHostetler

  • status changed from new to closed
  • resolution set to invalid

Link to that example no longer exists.

Changed 13 months ago by VexedPanda

  • status changed from closed to new
  • resolution invalid deleted

There's nothing stopping that example from being provided as part of a plugin, and the need to deal with magic quotes is more general. I still move we include that workaround into core.

Changed 13 months ago by alex94040

I'm OK with including this workaround to the core. We should still include warnings for folks to disable magic quotes - this will make things work faster if each script doesn't have to do the "stripslashes_array()" stuff.

Changed 13 months ago by VexedPanda

Here's the changes needed to add it to core, I'll see about modifying the config validator to warn about magic quotes.

Changed 13 months ago by VexedPanda

*Untested*! This should check for magic quotes, but allow config to continue regardless.

Changed 13 months ago by alex94040

  • status changed from new to in_QA

Code review feedback: great stuff. I haven't tested it, though.

Changed 13 months ago by VexedPanda

Updated to work with servers that don't support REMOTE_USER

Changed 12 months ago by alex94040

  • summary changed from Examples Site Config - Magic Quotes to Natively supporting servers with Magic Quotes=ON out of the box

Changed 10 months ago by alex94040

Just tested it on my PHP 5.2 box. Works with both magic quotes on and off.

Changed 10 months ago by alex94040

  • status changed from in_QA to closed
  • resolution set to fixed

(In [557]) Fixes #240: Natively supporting servers with Magic Quotes=ON out of the box. Code by VexedPanda?, review by alex94040.

Note: See TracTickets for help on using tickets.