Ticket #239 (closed defect: fixed)

Opened 16 months ago

Last modified 12 months ago

form draft generator - no translation support for edit links

Reported by: netcentrica Owned by: somebody
Priority: important Milestone: 1.0.1
Component: Codegen Version: 1.0.0 RC2
Keywords: edit link hard coded Cc:

Description

Hello

Form drafts are generated with 'edit' links, and that 'edit' links are hard-coded and are not passed by translation function so its impossible to automatically translate form to other language.

Example of generated form code:
$this->dtgDepartments->MetaAddEditLinkColumn?($strEditPageUrl, 'Edit', 'Edit');

should be rather something like:
$this->dtgDepartments->MetaAddEditLinkColumn?($strEditPageUrl, translate('Edit'), translate('Edit'));

Attachments

patch239.patch (0.9 kB) - added by alex94040 14 months ago.
Fix for the issue

Change History

Changed 14 months ago by alex94040

  • status changed from new to in_QA
  • milestone set to 1.0.1

We should fix this for both 1.0 and 1.1. Attaching a patch.

Changed 14 months ago by alex94040

Fix for the issue

Changed 13 months ago by VexedPanda

Looks great to me, please commit.

Changed 12 months ago by alex94040

  • status changed from in_QA to closed
  • resolution set to fixed

(In [521]) Fixes #239: form draft generator - no translation support for edit link. Applied to both 1.0 and 1.1 branches.

Code by netcentrica, reviewed by VexedPanda? and alex94040.

Note: See TracTickets for help on using tickets.