Ticket #211 (closed enhancement: fixed)

Opened 4 years ago

Last modified 18 months ago

New Control: Image Browser

Reported by: alex94040 Owned by:
Priority: minor Milestone: 2.1
Component: QControls Version: 1.0.0 RC2
Keywords: Cc: vakopian

Description

The control that Vakopian wrote ( http://www.qcodo.com/downloads/item.php/215) is a good demonstration on how to create a composite control - plus, it's a pretty useful component in and of itself. We should incorporate the control into the core and write an example around it - it would be just as useful as the File Upload composite control.

Attachments

QImageBrowser-1.1.zip Download (5.6 KB) - added by vakopian 18 months ago.
patch211_v2.patch Download (26.9 KB) - added by alex94040 18 months ago.
v2 of the patch
patch211_v3.patch Download (27.9 KB) - added by alex94040 18 months ago.
v3 of the patch

Change History

Changed 4 years ago by MikeHostetler

  • milestone changed from 1.1 to 1.2

Changed 4 years ago by alex94040

  • component changed from Framework to Plugin
  • milestone changed from 1.2 to Plugin

Changed 2 years ago by jmirancid

This ticket is up yet ? Because I already made a "image browser control" of my own for qCubed in a project.

With this control you can work with blob fields too if you want.

Can someone tell me if this ticket is valid so I can upload this control. Thank you.

Changed 2 years ago by alex94040

  • component changed from Plugin (not included in core distro) to QControls
  • milestone changed from Plugin to 2.0.3

This ticket IS valid - would love it if you could share your work.

Changed 18 months ago by alex94040

  • cc vakopian added
  • milestone changed from 2.1 to 2.2

Vakopian - can you reattach that control to this ticket, please? The qcodo link is invalid.

Changed 18 months ago by vakopian

It's still in qcodo's old downloads section:
 http://www.qcodo.com/wiki/old_downloads
 http://www.qcodo.com/wiki/download_file.php/205/QImageBrowser-1.1.zip

But just in case I'll attach it here

Changed 18 months ago by vakopian

Changed 18 months ago by alex94040

  • status changed from new to in_QA
  • milestone changed from 2.2 to 2.1

Changed 18 months ago by alex94040

v2 of the patch

Changed 18 months ago by alex94040

Just uploaded v2 of the patch:
- Made a very simple example using the control
- Hooked up the control into the appropriate folder
- Using prettier images in the example :-)

Please review!

Changed 18 months ago by vakopian

Looks nice with the new images :-)
I'm not sure if it's mentioned anywhere, but QImageControl requires the PHP GD module to be installed. It's probably worth mentioning this in these example pages (it was failing for me silently, I had to go dig in the http server logs to see what's going on).

Other than that it passed my test.

Also, this might be too much to ask, but if you get a chance, it would be great if the comments sections in the class files could be made into actual PHPDoc with @property and such.

Thanks Alex

Changed 18 months ago by alex94040

v3 of the patch

Changed 18 months ago by alex94040

New version of the patch:
- Vakopian's comments for v2 patch addressed
- Also changed the CSS of the example to look a tiny bit better by default (on-hover cursors, etc).

Changed 18 months ago by vakopian

Alex, there are some inconsistent indentations, but other than that looks great. Feel free to check it in.

Changed 18 months ago by alex94040

  • status changed from in_QA to closed
  • resolution set to fixed

(In [1372]) Fixes #211 (New Control: Image Browser). Code by Vakopian + alex94040, reviewed by Vakopian

Changed 18 months ago by alex94040

Fixed the indentations before checking in. Thanks, Vakopian!

Note: See TracTickets for help on using tickets.