Ticket #182 (assigned defect)

Opened 17 months ago

Last modified 4 weeks ago

QFileAssetDialog does not work inside a QForm

Reported by: alex94040 Owned by: somebody
Priority: minor Milestone: 1.0.4 Legacy Maintenance
Component: QForms Version: 1.0.0 Stable
Keywords: QFileAssetDialog, file upload, QFileAsset, QFile Cc:

Description

Only works inside a panel - there's an assumption inside that it has an objParentControl, not an objForm.

Attachments

QFileAssetDialog_patch.patch (0.7 kB) - added by alex94040 17 months ago.
Fix for the issue, with proper indentation
QFileAssetDialog-RenderAsFormChild.patch (0.7 kB) - added by enzo 14 months ago.

Change History

Changed 17 months ago by alex94040

Fix for the issue, with proper indentation

Changed 16 months ago by enzo

Hello folks

I'm checking the latest release 1.0 RC2, but I have an issue with QFileAsset, because in previous version the QDialog for QFileAsset was rendered outside the parent control. i.e

<form>
<control-fileasset>
<control-XXXXX>
<control-YYYYYY>
<control-fileasset-dialog> <--------- RIGHT PLACE
</form>

But using the latest version the html I get is

<form>
<control-fileasset>

<control-fileasset-dialog> <--------- WRONG PLACE

</control-fileasset>

<control-XXXXX>
<control-YYYYYY>
</form>

The problem with this structure is the dialog is not visible or only in part depending the parent width and height.

I tried to figure out by myself, but I couldn't find the source of this behavior

If someone could guide me in what part of code I could fix, I could fix by myself.

Regards.

enzo

Changed 16 months ago by basilieus

Looks fine alex, go ahead and patch.

Changed 16 months ago by marcosdsanchez

this should be checked in in both branches, 1.0 and 1.1

Changed 16 months ago by marcosdsanchez

  • status changed from new to in_QA

Changed 16 months ago by alex94040

  • component changed from Other to QForms
  • milestone changed from 1.1 to 1.0.0 Release

Setting the correct milestone.

Changed 16 months ago by alex94040

  • status changed from in_QA to closed
  • resolution set to fixed

(In [155]) Fixes #182 (QFileAssetDialog does not work inside a QForm). Code by alex94040, reviewed by Basilieus. Patching both 1.0 and 1.1 branches.

Changed 14 months ago by enzo

This problem persist.

I update to QCubed 1.1 but the QFileAsset control render the QDialog inside the control span, so the Dialog isn't visible.

Exanple at http://edukalia.anexusit.com/admin/students/add

If someone, could explain me in what part of code the dialog could be assign outside the control scope I could do by myself

please help

enzo

Changed 14 months ago by enzo

Hello folks

I did a change in QFileAssetDialog class to guaranty the modal window is a child of form, with this change I solve the issue to include in complex design with complex css.

The remain error is when the upload failure the position of window is render in a wrong position, someone could provide some clue to try to fix by myself.

Check a demo at : http://edukalia.anexusit.com/admin/students/QFileAsset/index.php

regards

enzo

P.S: please reopen this ticket I don't have rights to do that.

Changed 14 months ago by enzo

Changed 14 months ago by marcosdsanchez

  • status changed from closed to new
  • resolution fixed deleted

Changed 14 months ago by marcosdsanchez

  • status changed from new to in_QA

Enzo, your patch contains jquery code.

As this fix is for version 1.0 could you please refactor the javascript code to be compatible with qcodo instead of jquery?

Thanks for your patch :)

Changed 14 months ago by alex94040

  • version changed from 1.0.0 RC2 to 1.0.0 Stable
  • milestone changed from 1.0.0 Stable to 1.0.1

Changed 10 months ago by alex94040

  • milestone changed from 1.0.1 to 1.0.2

Changed 10 months ago by alex94040

  • status changed from in_QA to infoneeded

Changed 7 months ago by alex94040

  • milestone changed from 1.0.2 Stable to 1.0.3 Stable

Can someone re-roll this patch, please?

Changed 4 weeks ago by alex94040

  • status changed from infoneeded to assigned
  • milestone changed from 1.0.3 Legacy Maintenance to 1.0.4 Legacy Maintenance
Note: See TracTickets for help on using tickets.